[U-Boot] [PATCH v6 0/5] arm64 patch
Wolfgang Denk
wd at denx.de
Mon Sep 9 16:21:53 CEST 2013
Dear fenghua at phytium.com.cn,
In message <1378734616-37558-1-git-send-email-fenghua at phytium.com.cn> you wrote:
> From: David Feng <fenghua at phytium.com.cn>
>
> The porting has been merged with arm architecture.
> Most architecture codes are placed in arch/arm/cpu/armv8 directory.
> Generic board is also supported after a few bugs are fixed.
This patch series throws a large number of checkpatch warnings (like
line over 80 characters, space prohibited between function name and
open parenthesis, externs should be avoided in .c files, do not
initialise statics to 0 or NULL, trailing statements should be on next
line, Avoid CamelCase, do not use C99 // comments, please, no space
before tabs, ...) that need to be fixed.
Also, some constructs look pretty obscure and I wonder if they have
actually been tested; see for example here:
+#define S_X3 (24 /* offsetof(struct pt_regs, regs[3]) */
This does not look like correct code to me?
> Changes for v5:
> - Make modification to inappropriate licensed file and bugs according to ScottWood's advice.
> Thanks Scott for his checking to these patches.
> - Enable u-boot's running at EL1.
> - Get rid of compiling warnings originated from hashtable.c and cmd_pxe.c.
Please always provide a complete change log, including all patch
versions.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- driver executed.
More information about the U-Boot
mailing list