[U-Boot] [PATCH] powerpc/p2041: fix I2C controller's offset

Heiko Schocher hs at denx.de
Wed Sep 11 06:44:49 CEST 2013


Hello York,

Am 10.09.2013 23:14, schrieb York Sun:
> On 09/10/2013 02:13 PM, Chris Packham wrote:
>> Hi Xie,
>>
>> On Tue, Sep 10, 2013 at 8:15 PM, Shaohui Xie<Shaohui.Xie at freescale.com>  wrote:
>>> Without this patch, SPD access will fail which leads to DDR init fail.
>>>
>>> Signed-off-by: Shaohui Xie<Shaohui.Xie at freescale.com>
>>> ---
>>>   include/configs/P2041RDB.h |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)

Thanks for this fix!

>>> diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h
>>> index 905bacf..862614b 100644
>>> --- a/include/configs/P2041RDB.h
>>> +++ b/include/configs/P2041RDB.h
>>> @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
>>>   #define CONFIG_SYS_I2C_FSL
>>>   #define CONFIG_SYS_FSL_I2C_SPEED       400000
>>>   #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
>>> -#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
>>> +#define CONFIG_SYS_FSL_I2C_OFFSET      0x118000
>>>   #define CONFIG_SYS_FSL_I2C2_SPEED      400000
>>>   #define CONFIG_SYS_FSL_I2C2_SLAVE      0x7F
>>> -#define CONFIG_SYS_FSL_I2C2_OFFSET     0x3100
>>> +#define CONFIG_SYS_FSL_I2C2_OFFSET     0x118100
>>>
>>>   /*
>>>    * RapidIO
>>> --
>>> 1.7.0.4
>>>
>>
>> Yes that appears to fix the problem. Thanks for the quick turn around.
>>
>> Tested-by: Chris Packham<judge.packham at gmail.com>

Thanks for testing.

> Thanks for the feedback. I will take it in u-boot-mpc85xx.

Ah, Ok, I am fine with this, so:

Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list