[U-Boot] [PATCH] powerpc/t1040qds: Add T1040QDS board

[Wolfgang Denk]

Dear Prabhakar Kushwaha,

In message <1378880082-22319-1-git-send-email-prabhakar at freescale.com> you wrote:
> T1040QDS is a high-performance computing evaluation, development and
> test platform supporting the T1040 QorIQ Power Architecture™ processor.

Please fix this checkpatch issue:

WARNING: quoted string split across lines
#952: FILE: board/freescale/t1040qds/t1040qds.c:207:
+                       printf("Warning: SERDES bank %u expects reference clock"
+                              " %sMHz, but actual is %sMHz\n", i + 1,


> diff --git a/board/freescale/t1040qds/eth.c b/board/freescale/t1040qds/eth.c
> new file mode 100644
> index 0000000..c0604a4
> --- /dev/null
> +++ b/board/freescale/t1040qds/eth.c
...
> +void fdt_fixup_board_enet(void *fdt)
> +{
> +	return;
> +}

Is my understanding correct that there are no external callers except
in your own board code?  Then why do you define and call and empty
function at all?



> diff --git a/include/configs/T1040QDS.h b/include/configs/T1040QDS.h
> new file mode 100644
> index 0000000..2738242
> --- /dev/null
> +++ b/include/configs/T1040QDS.h
...
> +#define	CONFIG_EXTRA_ENV_SETTINGS				\
> +	"hwconfig=fsl_ddr:ctlr_intlv=cacheline,"		\
> +	"bank_intlv=cs0_cs1;"					\
> +	"usb1:dr_mode=host,phy_type=" __stringify(__USB_PHY_TYPE) "\0"\
> +	"netdev=eth0\0"						\
> +	"uboot=" __stringify(CONFIG_UBOOTPATH) "\0"		\
> +	"ubootaddr=" __stringify(CONFIG_SYS_TEXT_BASE) "\0"	\
> +	"tftpflash=tftpboot $loadaddr $uboot && "		\
> +	"protect off $ubootaddr +$filesize && "			\
> +	"erase $ubootaddr +$filesize && "			\
> +	"cp.b $loadaddr $ubootaddr $filesize && "		\
> +	"protect on $ubootaddr +$filesize && "			\
> +	"cmp.b $loadaddr $ubootaddr $filesize\0"		\
> +	"consoledev=ttyS0\0"					\
> +	"ramdiskaddr=2000000\0"					\
> +	"ramdiskfile=t1040qds/ramdisk.uboot\0"			\
> +	"fdtaddr=c00000\0"					\
> +	"fdtfile=t1040qds/t1040qds.dtb\0"			\
> +	"bdev=sda3\0"						\
> +	"c=ffe\0"
> +
> +#define CONFIG_LINUX                       \
> +	"setenv bootargs root=/dev/ram rw "            \
> +	"console=$consoledev,$baudrate $othbootargs;"  \
> +	"setenv ramdiskaddr 0x02000000;"               \
> +	"setenv fdtaddr 0x00c00000;"		       \
> +	"setenv loadaddr 0x1000000;"		       \
> +	"bootm $loadaddr $ramdiskaddr $fdtaddr"
> +
> +#define CONFIG_HDBOOT					\
> +	"setenv bootargs root=/dev/$bdev rw "		\
> +	"console=$consoledev,$baudrate $othbootargs;"	\
> +	"tftp $loadaddr $bootfile;"			\
> +	"tftp $fdtaddr $fdtfile;"			\
> +	"bootm $loadaddr - $fdtaddr"
> +
> +#define CONFIG_NFSBOOTCOMMAND			\
> +	"setenv bootargs root=/dev/nfs rw "	\
> +	"nfsroot=$serverip:$rootpath "		\
> +	"ip=$ipaddr:$serverip:$gatewayip:$netmask:$hostname:$netdev:off " \
> +	"console=$consoledev,$baudrate $othbootargs;"	\
> +	"tftp $loadaddr $bootfile;"		\
> +	"tftp $fdtaddr $fdtfile;"		\
> +	"bootm $loadaddr - $fdtaddr"
> +
> +#define CONFIG_RAMBOOTCOMMAND				\
> +	"setenv bootargs root=/dev/ram rw "		\
> +	"console=$consoledev,$baudrate $othbootargs;"	\
> +	"tftp $ramdiskaddr $ramdiskfile;"		\
> +	"tftp $loadaddr $bootfile;"			\
> +	"tftp $fdtaddr $fdtfile;"			\
> +	"bootm $loadaddr $ramdiskaddr $fdtaddr"
> +
> +#define CONFIG_BOOTCOMMAND		CONFIG_LINUX

Hm... we really need to find a way to get rid of such ever growing
(and repeating) env blocks...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real programmers can write assembly code in any language.   :-)
                      - Larry Wall in  <8571 at jpl-devvax.JPL.NASA.GOV>