[U-Boot] [PATCH v10 1/6] core support of arm64

[FengHua]

> -----原始邮件-----
> 发件人: "Scott Wood" <scottwood at freescale.com>
> 发送时间: 2013年9月17日 星期二
> 收件人: fenghua at phytium.com.cn
> 抄送: u-boot at lists.denx.de, trini at ti.com, albert.u.boot at aribaud.net, wd at denx.de, B45370 at freescale.com
> 主题: Re: [PATCH v10 1/6] core support of arm64
> 
> On Mon, 2013-09-16 at 16:08 +0800, fenghua at phytium.com.cn wrote:
> > From: David Feng <fenghua at phytium.com.cn>
> > 
> > Signed-off-by: David Feng <fenghua at phytium.com.cn>
> > ---
> 
> You've still got CONFIG_ARMV8 in places that should be CONFIG_ARM64

I am hesitate to use CONFIG_ARM64 instead of CONFIG _ARMV8.
I am not sure whether all the CONFIG_ARMV8 could be replaced with CONFIG_ARM64
or CONFIG_ARMV8 and CONFIG_ARMV64 are both needed.
I will take this into account in the next.

> 
> > diff --git a/arch/arm/cpu/armv8/exceptions.S b/arch/arm/cpu/armv8/exceptions.S
> > new file mode 100644
> > index 0000000..b2f62c9
> > --- /dev/null
> > +++ b/arch/arm/cpu/armv8/exceptions.S
> > @@ -0,0 +1,115 @@
> > +/*
> > + * (C) Copyright 2013
> > + * David Feng <fenghua at phytium.com.cn>
> > + *
> > + * SPDX-License-Identifier:	GPL-2.0+
> > + */
> 
> Note that Tom said he'd be OK with using GPL2-only code from Linux, as
> long as it's properly attributed.
>
Currently, the stack preservation code has no comparability with it's original copy.
I think it could be licensed with GPL-2.0+.

> > +2. GOT is used to relocate u-boot and CONFIG_NEEDS_MANUAL_RELOC is needed.
> > +
> > +3. Fdt should be placed at a 2-megabyte boundary and within the first 512
> > +   megabytes from the start of the kernel image. So, fdt_high should be
> > +   defined specially.
> > +   Please reference linux/Documentation/arm64/booting.txt for detail.
> > +
> > +4. Generic board is supported.
> > +
> > +Contributor:
> > +   Tom Rini       <trini at ti.com>
> > +   Scott Wood     <scottwood at freescale.com>
> > +   Sharma Bhupesh <B45370 at freescale.com>
> > +   Rob Herring    <robherring2 at gmail.com>
> 
> Should it be:
> Bhupesh Sharma <bhupesh.sharma at freescale.com>
> ?

It seems that Bhupesh Sharma own two mail box and he usually
use B45370 at freescale.com at u-boot mailing list. 
I will fix it in the next.

Best regards.

> -Scott
> 
> 
>