[U-Boot] [PATCH] mx6sabresd: Fix the fdt file for the mx6dl version

Eric Nelson eric.nelson at boundarydevices.com
Wed Sep 18 15:48:41 CEST 2013


Hi Fabio,

On 09/17/2013 06:55 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
>
> We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>   include/configs/mx6sabresd.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
> index a3dd74a..3229bc7 100644
> --- a/include/configs/mx6sabresd.h
> +++ b/include/configs/mx6sabresd.h
> @@ -16,7 +16,11 @@
>   #define CONFIG_MXC_UART_BASE	UART1_BASE
>   #define CONFIG_CONSOLE_DEV		"ttymxc0"
>   #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
> +#if defined(CONFIG_MX6Q)
>   #define CONFIG_DEFAULT_FDT_FILE	"imx6q-sabresd.dtb"
> +#elif defined(CONFIG_MX6DL)
> +#define CONFIG_DEFAULT_FDT_FILE	"imx6dl-sabresd.dtb"
> +#endif
>   #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
>
>   #include "mx6sabre_common.h"
>

As you know, we're loading the kernel using a boot script,
with various flavors for differing locations and environments,
so we've found it easier to pass environment variables for
board and CPU type to the boot script.
	https://github.com/boundarydevices/u-boot-imx6/commit/4a4fc304e4fe63cde7b3201f0daab5b1856870e4

This allows the boot script to produce the DTB name as shown
here:
	https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have
a separate choice as shown above.

Let me know your thoughts on this.

We didn't generate a proper patch for lack of time, but I
think that the small addition of code has merit. We also
may want to discuss the specifics in more detail.

Regards,


Eric


More information about the U-Boot mailing list