[U-Boot] i2c:zynq: I2C multi-bus support on Zynq

Heiko Schocher hs at denx.de
Thu Sep 19 07:29:42 CEST 2013


Hello Michael,

Am 18.09.2013 18:28, schrieb Michael Burr:
> This amends my previous patch (of Sept. 17, 2013, 5:29 p.m):
>> Initialize both bus masters as needed in 'i2c_init'.
> The behavior of this code should be unchanged from the
> old version if CONFIG_I2C_MULTI_BUS is not defined.
>
> According to Heiko, this driver should be ported to the new
> multibus framework (which I will try to do in the near
> future), so I don't expect this patch to be accepted now.
> I am submitting this only to make sure that the current
> iteration of my code is self-consistent (i.e. not broken!).
> This version may also be helpful to anyone who still has
> the older framework.
>
> Signed-off-by: Michael Burr<michael.burr at logicpd.com>
> Cc: Heiko Schocher<hs at denx.de>
> Cc: Michal Simek<monstr at monstr.eu>
> ---
>   drivers/i2c/zynq_i2c.c |   25 +++++++++++++++++++++----
>   1 file changed, 21 insertions(+), 4 deletions(-)

Hmm... I do not really understand what I should do now with
your patch? As you correct stated in your commit message,
I do not accept this patch ... so I mark your patch as
"Not Applicable"

BTW: such info is not good for a commit message. If you want to
add more info to your patch when submitting it, but this info
should not go into the commit message, as for example the info
what has changed between different patchversions, you can write such
text after the three "---". All text after this marker would not go
into the commit message.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list