[U-Boot] [PATCH 12/12 V3] DWMMC: SMDK5420: Disable SMU for eMMC

[Pantelis Antoniou]

Hi Rajesh, Simon,

On Sep 19, 2013, at 9:12 AM, Simon Glass wrote:

> Hi Rajeshwari,
> 
> On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde <rajeshwari.s at samsung.com> wrote:
> SMDK5420 has a new Security Management Unit added
> for dwmmc driver, hence, configuring the control
> registers to support booting via eMMC.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar at samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
> ---
> Changes in V3:
>         - New patch.
>  drivers/mmc/dw_mmc.c |  7 +++++++
>  include/dwmmc.h      | 12 ++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index a82ee17..d763949 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -300,6 +300,13 @@ static int dwmci_init(struct mmc *mmc)
>         struct dwmci_host *host = (struct dwmci_host *)mmc->priv;
>         u32 fifo_size;
> 
> +       dwmci_writel(host, EMMCP_MPSBEGIN0, 0);
> +       dwmci_writel(host, EMMCP_SEND0, 0);
> +       dwmci_writel(host, EMMCP_CTRL0,
> +               MPSCTRL_SECURE_READ_BIT | MPSCTRL_SECURE_WRITE_BIT |
> +               MPSCTRL_NON_SECURE_READ_BIT | MPSCTRL_NON_SECURE_WRITE_BIT |
> +               MPSCTRL_VALID);
> +
> 
> Is this safe for all users of this file (Exynos5250, etc. ?
> 

Same objection here. If it's not safe ifdef CONFIG it.

> Regards,
> Simon
> 

Regards

-- Pantelis