[U-Boot] [PATCH v2] FIT: delete unnecessary casts
Jeroen Hofstee
jeroen at myspectrum.nl
Thu Sep 19 19:22:36 CEST 2013
On 09/19/2013 05:10 AM, Masahiro Yamada wrote:
> Becuase fdt_check_header function takes (const void *)
> type argument, the argument should be passed to it
> without being casted to (char *).
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> ---
>
> Changes for v2:
> - fix commit log (purely cosmetic)
> (s/img_addr/the argument/)
>
>
> common/image-fdt.c | 2 +-
> common/image-fit.c | 2 +-
> common/image.c | 6 +-----
> tools/fit_image.c | 2 +-
> 4 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/common/image-fdt.c b/common/image-fdt.c
> index 2e22cca..6f9ce7d 100644
> --- a/common/image-fdt.c
> +++ b/common/image-fdt.c
> @@ -55,7 +55,7 @@ static const image_header_t *image_get_fdt(ulong fdt_addr)
> fdt_error("uImage is compressed");
> return NULL;
> }
> - if (fdt_check_header((char *)image_get_data(fdt_hdr)) != 0) {
> + if (fdt_check_header((void *)image_get_data(fdt_hdr)) != 0) {
> fdt_error("uImage data is not a fdt");
> return NULL;
> }
Not that I care, this is fine with me. Was just
wondering if this cast is needed at all. AFAIK
it is a cpp thing (and MSVC?) to require it.
Regards,
Jeroen
More information about the U-Boot
mailing list