[U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Change clock definition of SCIF from CONFIG_SYS_CLK_FREQ to CONFIG_SH_SCIF_CLK_FREQ

Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj at renesas.com
Fri Sep 20 02:21:16 CEST 2013


Hi, Albert.

(2013/09/19 18:09), Albert ARIBAUD wrote:
> Hi Nobuhiro,
>
> On Thu, 22 Aug 2013 13:05:49 +0900, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj at renesas.com>  wrote:
>
>> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj at renesas.com>
>> ---
>>   include/configs/kzm9g.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/kzm9g.h b/include/configs/kzm9g.h
>> index 222725c..6323050 100644
>> --- a/include/configs/kzm9g.h
>> +++ b/include/configs/kzm9g.h
>> @@ -125,6 +125,7 @@
>>   #define CONFIG_GLOBAL_TIMER
>>   #define CONFIG_SYS_CLK_FREQ	(48000000)
>>   #define CONFIG_SYS_CPU_CLK	(1196000000)
>> +#define CONFIG_SH_SCIF_CLK_FREQ CONFIG_SYS_CLK_FREQ
>>   #define TMU_CLK_DIVIDER		(4)	/* 4 (default), 16, 64, 256 or 1024 */
>>   #define CFG_HZ              (1000)
>>   #define CONFIG_SYS_HZ		CFG_HZ
>
> What's the point of this series? It only adds a define, but the
> current codebase does not use it anywhere, so obviously it's "dead
> code".

This is used by drivers/serial/serial_sh.c.
   http://lists.denx.de/pipermail/u-boot/2013-August/161276.html

I already applied this to my u-boot-sh repository. But I dont pull-request yet.
I want to include in the next version of this change.
 >
> If there is a further series which needs this define, then
> include these patches in that further series.

I see. I will be from next time, Is it OK?

>
> Amicalement,

Best regards,
   Nobuhiro


More information about the U-Boot mailing list