[U-Boot] [PATCH V4 04/17] usb: gadget: ether: return error from rx_submit if no request

Marek Vasut marex at denx.de
Fri Sep 20 12:52:31 CEST 2013


Dear Troy Kisky,

> This prevents a crash if tftpboot is given a bad filename.
> 
> rx_req will be released by eth_reset_config
> which is called by eth_disconnect,
> which is called using the .disconnect member of usb_gadget_driver by
> mv_pullup in mv_udc which is called using the .pullup member of
> usb_gadget_ops by usb_gadget_disconnect which is called by usb_eth_halt
> which is called using the .halt member of eth_device by eth_halt
> which is called by TftpHandler when TFTP_ERR_FILE_NOT_FOUND or
> TFTP_ERR_ACCESS_DENIED occurs
> 
> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
> 

How do I trigger this? It'd be nice to have a test-case in the commit message.

Best regards,
Marek Vasut


More information about the U-Boot mailing list