[U-Boot] [PATCH v2] net: fec_mxc: Fix timeouts during tftp transfer

Stefano Babic sbabic at denx.de
Fri Sep 20 18:11:23 CEST 2013


On 18/09/2013 04:13, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Performing tftp transfers on mx28 results in random timeouts.
> 
> Hector Palacios and Robert Hodaszi analyzed the root cause being related to the 
> wrong alignment of the 'buff' buffer inside fec_recv().
> 
> Benoît Thébaudeau provided an excellent analysis of the alignment bug that is
> present on older versions, such as GCC 4.5.4:
> 
> http://marc.info/?l=u-boot&m=137942904906131&w=2 
> 
> Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC 
> versions.
> 
> Reported-by: Hector Palacios <hector.palacios at digi.com>
> Tested-by: Oliver Metz <oliver at freetz.org>
> Tested-by: Hector Palacios <hector.palacios at digi.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list