[U-Boot] [PATCH 3/3] mx35pdk: Fix error handling in board_late_init()
Fabio Estevam
festevam at gmail.com
Fri Sep 20 21:30:50 CEST 2013
From: Fabio Estevam <fabio.estevam at freescale.com>
If smc911x_initialize() fails we should return the error immediately.
While at it, also check the error from cpu_eth_init().
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
board/freescale/mx35pdk/mx35pdk.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/board/freescale/mx35pdk/mx35pdk.c b/board/freescale/mx35pdk/mx35pdk.c
index 427c83a..9fabef5 100644
--- a/board/freescale/mx35pdk/mx35pdk.c
+++ b/board/freescale/mx35pdk/mx35pdk.c
@@ -251,14 +251,12 @@ int board_late_init(void)
int board_eth_init(bd_t *bis)
{
- int rc = -ENODEV;
#if defined(CONFIG_SMC911X)
- rc = smc911x_initialize(0, CONFIG_SMC911X_BASE);
+ int rc = smc911x_initialize(0, CONFIG_SMC911X_BASE);
+ if (rc)
+ return rc;
#endif
-
- cpu_eth_init(bis);
-
- return rc;
+ return cpu_eth_init(bis);
}
#if defined(CONFIG_FSL_ESDHC)
--
1.8.1.2
More information about the U-Boot
mailing list