[U-Boot] [PATCH v3 02/28] sf: probe: Add new spi_flash_probe support

[Sascha Silbe]

Hi Jagannadha,

Jagannadha Sutradharudu Teki <jagannadha.sutradharudu-teki at xilinx.com>
writes:

> Added new spi_flash_probe support, currently added N25Q*
> flash part attributes support.
[...]

I've given your series another try on Cubox. It looks better this time
(e.g. the probe issue is gone), but there are still a couple of
issues. I'm going to reply to each of the affected patches (2, 7, 14)
individually so it shows up properly in Patchwork.


This patch causes a major regression and thus breaks bisectability. It
rips out support for all SPI flash chips except for STMICRO ones, unless
CONFIG_SPI_FLASH_LEGACY is defined. However, CONFIG_SPI_FLASH_LEGACY
doesn't get defined anywhere.

A better approach would be to make the new code opt-in rather than
opt-out, and selecting it automatically for CONFIG_SPI_FLASH_<vendor> as
support for each vendor is added.


PS: What's the etiquette for the CC list of replies to patches? Keep
    all original recipients CC'ed? Or should I have dropped the chip
    vendor contacts for this reply?

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130921/83bc2ee1/attachment.pgp>