[U-Boot] [PATCH 01/12 V3] EXYNOS5: Create a common board file

[Rajeshwari Birje]

Hi Simon,

On Sat, Sep 21, 2013 at 8:11 AM, Simon Glass <sjg at chromium.org> wrote:

> Hi Rajeshwari,
>
> On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde <
> rajeshwari.s at samsung.com> wrote:
>
> > Create a common board.c file for all functions which are common across
> > all EXYNOS5 platforms.
> >
> > exynos_init function is provided for platform cpecific code.
> >
> > Signed-off-by: Rajeshwari S Shinde <rajeshwari.s at samsung.com>
> >
>
> I have a few more comments after trying this out on Pit.
>
> My source tree is here, in branch try-5420.
>
> git://git.denx.de/u-boot-x86.git
>
> This includes a few modifications to your patches to make them apply on
> mainline, and also one patch to fix Pit:
>
> - add a device tree
> - fix a few defines (CONFIG_POWER... instead of CONFIG_PMIC)
> - define CONFIG_POWER to get PS HOLD asserted (otherwise it powers off
> after 1 second)
> - disable MAX77686 PMIC (there is no driver for 77802)
> - remove PMIC code in smdk5420.c since it is already in
> board/samsung/common/board.c
> - serial support for SPL, not really needed
> - fix boards.cfg format
> - hack tools/Makefile
>
> With this I can boot to a prompt on Pit (I just type 'crosfw' inside the
> Chrome OS chroot to build and download over USB). I suspect SMDK5420 does
> not need PS_HOLD, and I think your PMIC code is not being included.
>
> I hope this helps with your patch preparation for v4 - it would be great if
> you could include Pit support as well as smdk5420. Hopefully they can use
> the same config, just a different device tree.
>
> Regards,
> Simon
> Okay, will insert these too before sending a V4 patch.
>
-- 
Regards,
Rajeshwari Shinde

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>