[U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard

Wolfgang Denk wd at denx.de
Mon Sep 23 20:50:55 CEST 2013


Dear Fabio Estevam,

In message <CAOMZO5Aj56KVTfRqBd3Wq7OiP8q3wA0Yv4evUzerkXFuFvxvHQ at mail.gmail.com> you wrote:
>
> > Then shouldn't the patch subject/summary be "print command name only
> > if cmdtp is not NULL" rather than the quite uninformative "prevent a
> > crash"?
> 
> Yes, I agree that original subject is a bit misleading.
> 
> When I read it I thought it was a Wandboard related problem.

I don't know if it's only Wandboard, or if other boards are affected,
too (which are these? under which exact test cases?).  In any case.
the problem is not here, but on the caller's side.  It should not call
a function which expects a command name with a NULL pointer passed as
argument.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
            - R.  Pirsig, "Zen and the Art of Motorcycle Maintenance"


More information about the U-Boot mailing list