[U-Boot] [PATCH] ARM: mxs: tools: Use mkimage for BootStream generation

Marek Vasut marex at denx.de
Tue Sep 24 18:31:47 CEST 2013


Dear Otavio Salvador,

> On Tue, Sep 24, 2013 at 12:25 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> On Tue, Sep 24, 2013 at 11:51 AM, Marek Vasut <marex at denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> > 
> >> >> On Tue, Sep 24, 2013 at 11:40 AM, Marek Vasut <marex at denx.de> wrote:
> >> >> > Now that mkimage can generate an BootStream for i.MX23 and i.MX28,
> >> >> > use the mkimage as a default tool to generate the BootStreams
> >> >> > instead of the elftosb tool. This cuts out another obscure
> >> >> > dependency.
> >> >> > 
> >> >> > Signed-off-by: Marek Vasut <marex at denx.de>
> >> >> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> >> >> > Cc: Otavio Salvador <otavio at ossystems.com.br>
> >> >> > Cc: Stefano Babic <sbabic at denx.de>
> >> >> > ---
> >> >> > 
> >> >> >  arch/arm/cpu/arm926ejs/mxs/Makefile          | 11 +++++----
> >> >> >  arch/arm/cpu/arm926ejs/mxs/mxsimage.mx23.cfg |  4 ++--
> >> >> >  arch/arm/cpu/arm926ejs/mxs/mxsimage.mx28.cfg |  4 ++--
> >> >> >  doc/README.mxs                               | 34
> >> >> >  +++++++++++++++++++++++++--- 4 files changed, 41 insertions(+), 12
> >> >> >  deletions(-)
> >> >> > 
> >> >> > diff --git a/arch/arm/cpu/arm926ejs/mxs/Makefile
> >> >> > b/arch/arm/cpu/arm926ejs/mxs/Makefile index 3d66892..3e9cbdb 100644
> >> >> > --- a/arch/arm/cpu/arm926ejs/mxs/Makefile
> >> >> > +++ b/arch/arm/cpu/arm926ejs/mxs/Makefile
> >> >> > @@ -25,14 +25,15 @@ $(LIB):     $(OBJS)
> >> >> > 
> >> >> >         $(call cmd_link_o_target, $(OBJS))
> >> >> >  
> >> >> >  # Specify the target for use in elftosb call
> >> >> > 
> >> >> > -ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
> >> >> > -ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
> >> >> > +ELFTOSB_TARGET-$(CONFIG_MX23) = mx23
> >> >> > +ELFTOSB_TARGET-$(CONFIG_MX28) = mx28
> >> >> 
> >> >> Uh?! this seems wrong.
> >> > 
> >> > Why ?
> >> 
> >> elftosb uses the former way; in case you might change the target var
> >> for:
> >> 
> >> MXSIMAGE_TARGET
> >> 
> >> So this does not cause confusion.
> > 
> > OK. Next time you could include such vital information in your first
> > email.
> 
> Next time you can say 'thank you'. Such politeness helps collaborative work
> ;-)

Fixed (lol).

Best regards,
Marek Vasut


More information about the U-Boot mailing list