[U-Boot] [PATCH v3] ARM: mxs: tools: Use mkimage for BootStream generation

[Otavio Salvador]

On Tue, Sep 24, 2013 at 1:28 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Tue, Sep 24, 2013 at 12:39 PM, Marek Vasut <marex at denx.de> wrote:
>> > Now that mkimage can generate an BootStream for i.MX23 and i.MX28,
>> > use the mkimage as a default tool to generate the BootStreams instead
>> > of the elftosb tool. This cuts out another obscure dependency.
>> >
>> > Signed-off-by: Marek Vasut <marex at denx.de>
>>
>> ..
>>
>> >  # Specify the target for use in elftosb call
>> >
>> > -ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
>> > -ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
>> > +MKIMAGE_TARGET-$(CONFIG_MX23) = mx23
>> > +MKIMAGE_TARGET-$(CONFIG_MX28) = mx28
>> >
>> > -$(OBJTREE)/u-boot.bd:
>> > $(SRCTREE)/$(CPUDIR)/$(SOC)/u-boot-$(ELFTOSB_TARGET-y).bd
>> > +$(OBJTREE)/mxsimage.cfg:
>> > $(SRCTREE)/$(CPUDIR)/$(SOC)/mxsimage.$(MKIMAGE_TARGET-y).cfg
>> >
>> >         sed "s at OBJTREE@$(OBJTREE)@g" $^ > $@
>>
>> This is clearly a mxsimage thing; I do believe MXSIMAGE_TARGET is more
>> clear.
>
> Please read the patch again, the tool that is invoked is called "mkimage" . I
> disagree.

But it is used to generate the mxsimage.cfg in
.../mxsimage.$(MKIMAGE_TARGET-y).cfg

So it is really an mxsimage thing.

For something named MKIMAGE_TARGET I would expect it being in the mkimage call.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750