[U-Boot] [PATCH v2] drivers/net/designware - fix alignment of buffer descriptors

[Mischa Jonker]

Vipin wrote:
> I have also faced this problem before. May be a better solution is to
> place all the struct and buffer declarations at the very start of
> dw_eth_dev structure (off-course with a comment that these should not
> be moved). It may avoid the problem in later modifications

I think that's why Alexey added the alignment to the struct dmamacdescr declaration, to make sure that it always aligned on a boundary of 16 bytes (so even 128-bit busses don't face this issue).

I don't know though whether the __aligned attribute should be at the type definition of the struct or at the declaration of the "struct dmamacdescr" inside "struct dw_eth_dev". I'm guessing the declaration inside "struct dw_eth_dev" will inherit the alignment requirements of the type def though, but not sure.

Mischa