[U-Boot] [PATCH 01/10] arm: vf610: fix anadig register struct

Marcel Ziswiler marcel at ziswiler.com
Mon Sep 30 10:19:29 CEST 2013


On 09/17/2013 03:27 PM, Otavio Salvador wrote:
> I agree with the way to fix it but it is a little bit hard to get it 
> is a 'reserved'; we used reserved_<where> to make it more explicit. 
> Take a look at 
> http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/include/asm/arch-mxs/regs-power-mx28.h;h=9528e3ce9ad805ec30a1c0595924dbddb296c50f 
> for an usage example. 

At the end of the day those reserved fields are just memory holes in the 
register set. I don't think they really belong to either the previous 
last nor the first next valid register. Also I don't really see how the 
naming convention in use at above mentioned link is much more consistent.

If we really do want do change the way this is done then probably naming 
it after the actual memory offset would be most helpful (e.g. 
reserved_0x014[3]). If you agree I will cook up a new patch series in 
that respect.


More information about the U-Boot mailing list