[U-Boot] ahci: Fix data abort on multiple scsi resets.

Tom Rini trini at ti.com
Wed Apr 2 23:18:27 CEST 2014


On Tue, Apr 01, 2014 at 05:26:40PM +0300, Roger Quadros wrote:

> Commit 2faf5fb82ed6 introduced a regression that causes a data
> abort when running scsi init followed by scsi reset.
> 
> There are 2 problems with the original commit
> 1) ALLOC_CACHE_ALIGN_BUFFER() allocates memory on the stack but is
> assigned to ataid[port] and used by other functions.
> 2) The function ata_scsiop_inquiry() tries to free memory which was
> never allocated on the heap.
> 
> Fix these problems by using tmpid as a temporary cache aligned buffer.
> Allocate memory separately for ataid[port] and re-use it if required.
> 
> Fixes: 2faf5fb82ed6 (ahci: Fix cache align error messages)
> 
> Reported-by: Eli Nidam <elini at marvell.com>
> Signed-off-by: Roger Quadros <rogerq at ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140402/a8c38e09/attachment.pgp>


More information about the U-Boot mailing list