[U-Boot] [PATCH v3 06/13] USB: gadget: added a saner gadget downloader registration API

Marek Vasut marex at denx.de
Thu Apr 3 10:52:17 CEST 2014


On Thursday, April 03, 2014 at 09:46:22 AM, Lukasz Majewski wrote:
> Hi Marek,
> 
> > On Wednesday, April 02, 2014 at 08:35:33 AM, Lukasz Majewski wrote:
> > > Hi Mateusz,
> > 
> > [...]
> > 
> > > Acked-by: Lukasz Majewski <l.majewski at samsung.com>
> > 
> > I suggest this goes for -next. Do you agree?
> 
> I'm fine with this code going to -next. Thanks in advance.

Hm, actually, I see we have open issues with the 04/13 V2 patch (why don't you 
have default __weak usb_cable_detection() implementation instead of another 
#ifdef ?).

The whole patchset is a mix of completely unrelated things which should go 
through different trees. Can the patchset be reordered/split in some reasonable 
chunks ? There are fixes which should go in immediatelly and then features which 
should go in for -next.

btw. please keep custodians on CC of the respective patches.

Best regards,
Marek Vasut


More information about the U-Boot mailing list