[U-Boot] [Question] bardrate both in gd_t and bd_t

Tom Rini trini at ti.com
Thu Apr 3 22:01:08 CEST 2014


On Wed, Apr 02, 2014 at 04:12:24PM +0900, Masahiro Yamada wrote:
> Hi.
> 
> I notice bardrate parameter bd_t as well as gd_t.
> 
> 
> In include/asm-generic/global_data.h
> 
> typedef struct global_data {
> 	bd_t *bd;
> 	unsigned long flags;
> 	unsigned int baudrate;
> 
> We have "baudrate" here.
> 
> 
> 
> 
> E.g. arch/arm/include/asm/u-boot.h
> 
> typedef struct bd_info {
> 	unsigned int	bi_baudrate;	/* serial console baudrate */
> 
> We have "bi_baudrate".
> 
> 
> 
> My question is what's the difference
> between gd->baudrate and bd->bi_baudrate.
> Why do we need both?
> 
> Since baudrate is a common paramter for all architectures,
> bd->bi_baudrate looks weird to me.

I think the answer is sadly just duplicated datastructures.  Simon do
you recall why we didn't drop this duplication before?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140403/67126e53/attachment.pgp>


More information about the U-Boot mailing list