[U-Boot] [PATCH] build:arm: Remove setting of CROSS_COMPILE environment variable

[Lukasz Majewski]

Hi Albert,

> Hi Albert,
> 
> > Hi Albert,
> > 
> > > Hi Lukasz,
> > > 
> > > On Tue, 25 Mar 2014 09:55:45 +0100, Lukasz Majewski
> > > <l.majewski at samsung.com> wrote:
> > > 
> > > > Hi Albert,
> > > > 
> > > > > Hi Lukasz, Tom,
> > > > > 
> > > > > 
> > > > > > Hi Tom,
> > > > > > 
> > > > > > > On Tue, Mar 18, 2014 at 04:46:48PM +0100, Lukasz Majewski
> > > > > > > wrote:
> > > > > > > 
> > > > > > > > After Kbuild introduction, the CROSS_COMPILE environment
> > > > > > > > variable has been set to some default value (prefix
> > > > > > > > arm-linux-).
> > > > > > > 
> > > > > > > Note that this is quite a long-standing thing.  Perhaps
> > > > > > > we're now not detecting a native build when we used to?
> > > > > > 
> > > > > > My point is that we are relying on assigning default prefix
> > > > > > (i.e. arm-linux-)
> > > > > > 
> > > > > > For example OSELAS toolchains can have an arbitrary prefix
> > > > > > (e.g. arm-linux-gnueabi-).
> > > > > > 
> > > > > > When I cross compile I set explicitly
> > > > > > "CROSS_COMPILE=<toolchain> make" and it works as it should
> > > > > > (with or without this patch). Such approach seems natural
> > > > > > for me.
> > > > > >
> > > > > > However, I don't know what is the exact rationale for seting
> > > > > > this arm-linux- prefix to CROSS_COMPILE.
> > > > > > I can only guess, that it is connected with situation when
> > > > > > one just type "make" on x86_64 host and expect u-boot to be
> > > > > > CROSS_COMPILE'd out of the box.
> > > > > 
> > > > > Agree.
> > > > > It is useful only for people using "arm-linux-gcc" on x86
> > > > > host. I usually use "arm-linux-gnueabi-gcc". Someone else may
> > > > > be using other prefixes.
> > > > > 
> > > > > I think there is no rationale more sophisticated than that it
> > > > > just has been there since long time before.
> > > > > 
> > > > > So, I agree with this patch except a little misleading
> > > > > commit description I commented below.
> > > > > 
> > > > > Acked-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> > > > > 
> > > > 
> > > > Albert, could you take this patch for your arm repository?
> > > 
> > > I can. How would you like me to rephrase the commit message?
> > 
> > Maybe something like this:
> > 
> > -- 8< --
> > For building u-boot on ARM the CROSS_COMPILE environment variable,
> > when not defined, was set to default value (prefix arm-linux-).
> > 
> > Since not all cross compilers have the arm-linux- prefix and this
> > setting prevents from building u-boot on natively arm powered
> > devices it would be best to remove it.
> > 
> > As a side note:
> > The most universal way to cross compile u-boot is to
> > specify the CROSS_COMPILE environment variable explicitly - e.g.:
> > CROSS_COMPILE=/ .... /arm-v7a-linux-gnueabi- make
> > 
> > -- >8 --
> > 
> > And also please add the Acked-by from Masahiro.
> 
> Albert, do you need any more support to pull this patch to u-boot-arm
> branch?

Are you willing to add this patch to your u-boot-arm tree? 

I know that you were not available on the ML for some time and hence,
I'm curious if you plan to send pull request for u-boot-arm tree to Tom
before the v2014.04 release?

> 
> > 
> > > 
> > > Amicalement,
> > 
> > Thanks a lot for your support.
> > 
> 
> 
> 

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group