[U-Boot] [PATCH] Fix USB keyboard polling via control endpoint

Adrian Cox adrian at humboldt.co.uk
Thu Apr 10 10:49:56 CEST 2014


> From: "Marek Vasut" <marex at denx.de>

> Also, this USB_KBD_PDATA_SIZE should instead be called
> "USB_KBD_LS_REPORT_SIZE"
> [...]
> What worries me a bit is that 64-byte high-speed report, but I never
> saw a
> device that would generate those. This section 5.6 is also the only
> place that
> mentions the high-speed HID device report size limit.

How about renaming to USB_KBD_BOOT_REPORT_SIZE? We know that the keyboard report will
be 8 bytes because we explicitly set the keyboard into boot protocol
(Appendix B of HID 1.11: "The report may not exceed 8 bytes in length.").

Regards,
Adrian Cox



More information about the U-Boot mailing list