[U-Boot] [PATCH] mx6slevk: Add SPI NOR flash support

[Jagan Teki]

On Sun, Apr 13, 2014 at 2:29 AM, Marek Vasut <marex at denx.de> wrote:
> On Saturday, April 12, 2014 at 07:50:35 PM, Jagan Teki wrote:
> [...]
>
>> >> > diff --git a/include/configs/mx6slevk.h b/include/configs/mx6slevk.h
>> >> > index 1876dbf..3d05a64 100644
>> >> > --- a/include/configs/mx6slevk.h
>> >> > +++ b/include/configs/mx6slevk.h
>> >> > @@ -10,6 +10,7 @@
>> >> >
>> >> >  #define __CONFIG_H
>> >> >
>> >> >  #include <asm/arch/imx-regs.h>
>> >> >
>> >> > +#include <asm/imx-common/gpio.h>
>> >> >
>> >> >  #include <linux/sizes.h>
>> >> >  #include "mx6_common.h"
>> >> >
>> >> > @@ -196,4 +197,15 @@
>> >> >
>> >> >  #define CONFIG_CMD_CACHE
>> >> >  #endif
>> >> >
>> >> > +#define CONFIG_CMD_SF
>> >> > +#ifdef CONFIG_CMD_SF
>> >> > +#define CONFIG_SPI_FLASH
>> >> > +#define CONFIG_SPI_FLASH_STMICRO
>> >> > +#define CONFIG_MXC_SPI
>> >> > +#define CONFIG_SF_DEFAULT_BUS          0
>> >>
>> >> *no_need* to define DEFAULT_BUS as 0 - it's default.
>> >
>> > We better be explicit here.
>>
>> *explicit* fine - don't you think defining a default value may
>> increase extra macro which looks *duplicate*
>
> No.
>
> Explicitly defining the value in the board file serves well for people who will
> dig in the SPI on this particular MX6 board as it will make it immediatelly
> clear to them which SPI bus is the SPI NOR sitting on. It makes things easily
> tweakable as well.

Ok.

> Also, is there any reason to put asterisks around random words in the sentence?
For important words in a sentence.

I saw could be see couple of warnings on this.

Reviewed-by: Jagannadha Sutradharudu Teki <jaganna at xilinx.com>

thanks!
-- 
Jagan.