[U-Boot] [PATCH 2/2] usb: r8a66597: Fix initilization size of r8a66597 info, structure

Marek Vasut marex at denx.de
Thu Apr 17 16:09:00 CEST 2014


On Thursday, April 17, 2014 at 10:20:29 AM, yasuhisa umano wrote:
> Initialization of r8a66597 info structure is not enough.
> Because initilization was used size of pointer.
> This fixes that use size of r8a6659 info structure.
> 
> Signed-off-by: Yasuhisa Umano <yasuhisa.umano.zc at renesas.com>
> ---
>  drivers/usb/host/r8a66597-hcd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/r8a66597-hcd.c
> b/drivers/usb/host/r8a66597-hcd.c index c58d2a9..8e82212 100644
> --- a/drivers/usb/host/r8a66597-hcd.c
> +++ b/drivers/usb/host/r8a66597-hcd.c
> @@ -807,7 +807,7 @@ int usb_lowlevel_init(int index, enum usb_init_type
> init, void **controller)
> 
>  	R8A66597_DPRINT("%s\n", __func__);
> 
> -	memset(r8a66597, 0, sizeof(r8a66597));
> +	memset(r8a66597, 0, sizeof(struct r8a66597));

Let's use sizeof(*r8a66597) instead . This is more scalable as you won't need to 
adjust this code when you change the data type of the *r8a66597 pointer,

I will adjust that and apply with sizeof(*r8a66597); , does that work for you?

Best regards,
Marek Vasut


More information about the U-Boot mailing list