[U-Boot] [PATCH 3/5] blackfin: replace bfin_gen_rand_mac() with eth_random_addr()

Masahiro Yamada yamada.m at jp.panasonic.com
Fri Apr 18 11:25:56 CEST 2014


Hi Mike,

On Thu, 17 Apr 2014 15:07:50 -0400
Mike Frysinger <vapier at gentoo.org> wrote:

> On Thu 17 Apr 2014 17:00:30 Masahiro Yamada wrote:
> > --- a/include/configs/tcm-bf537.h
> > +++ b/include/configs/tcm-bf537.h
> > @@ -73,7 +73,7 @@
> >  #define CONFIG_HOSTNAME		tcm-bf537
> >  /* Uncomment next line to use fixed MAC address */
> >  /* #define CONFIG_ETHADDR	02:80:ad:20:31:e8 */
> > -
> > +#define CONFIG_LIB_RAND
> 
> this should be in bfin_adi_common.h instead.  i think that replaces the 
> majority of your config updates (if not all).
> -mike

Are you sure?

There are 35 blackfin boards in boards.cfg.
There are only 15 boards using random MAC address.


Besides, I think your suggestion does not work
because for ex.  bf537-minotaur board is not including bfin_adi_common.h.




Best Regards
Masahiro Yamada



More information about the U-Boot mailing list