[U-Boot] [PATCH] lib/sha256: fix compile on some hosts

Bo Shen voice.shen at gmail.com
Sun Apr 20 15:18:07 CEST 2014


Hi Andreas,

On 04/20/2014 04:34 PM, Andreas Bießmann wrote:
> Commit 2842c1c24269a05142802d25520e7cb9035e456c introduced lib/sha256 into
> mkimage. Since then it will be compiled with HOSTCC which may produce errors
> on some systems. Most BSD systems (like OS X for me) do not ship a
> linux/string.h which will lead to take the U-Boot provided
> include/linux/string.h in the end. This header howver is completely wrong

s/howver/however

> here. Just take the string.h if compiling with HOSTCC and linux/string.h when
> not.
>
> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> Cc: Heiko Schocher <hs at denx.de>
> ---
>
>   lib/sha256.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/sha256.c b/lib/sha256.c
> index 3212bab..b1085ea 100644
> --- a/lib/sha256.c
> +++ b/lib/sha256.c
> @@ -8,9 +8,11 @@
>
>   #ifndef USE_HOSTCC
>   #include <common.h>
> +#include <linux/string.h>
> +#else
> +#include <string.h>
>   #endif /* USE_HOSTCC */
>   #include <watchdog.h>
> -#include <linux/string.h>
>   #include <sha256.h>
>
>   /*

Best Regards,
Bo Shen



More information about the U-Boot mailing list