[U-Boot] [PATCH 2/2] patman: Avoid duplicate sign-offs

Simon Glass sjg at chromium.org
Sun Apr 20 18:51:25 CEST 2014


Hi Masahiro,

On 27 March 2014 22:42, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:

> Hi Simon,
>
>
> > Collect all Signed-off-by tags in a commit and make sure that there are
> > no duplicates.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
>
> I have a change request about this patch.
>
> It is true this patch avoids duplication, but
> it changes the order *-by: credits.
>
>
>
> For example, assume something like this in my git-log
>
> blah blah blah
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Reported-by: For Bar <foo at bar.com>
>
>
>
> Patman changes it to
>
> blah blah blah
>
> Reported-by: For Bar <foo at bar.com>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>
>
>
> I want Patman to touch *-by: credits only when it is really necessary.
>  [1] when adding a missing Signed-off-by:
>  [2] when deleting redundant Signed-off-by:
>
>
>
Yes I agree that is better - I will update the patch and resend as v2.

Regards,
Simon


More information about the U-Boot mailing list