[U-Boot] [PATCH] exynos: usb: Fix data abort on boards w/o vbus-gpio node in the DT

Marek Vasut marex at denx.de
Wed Apr 23 15:17:59 CEST 2014


On Tuesday, April 22, 2014 at 07:23:49 PM, andrey.konovalov at linaro.org wrote:
> Commit 4a271cb1b4ff doesn't take into account that fdtdec_setup_gpio()
> returns success when the gpio passed to it is FDT_GPIO_NONE (no
> gpio node found in the fdtdec_decode_gpio() call). This results in
> calling gpio_direction_output() on invalid gpio. For this reason
> executing "usb start" command on Arndale causes data abort in the
> ehci-exynos driver.
> 
> Add the fdt_gpio_isvalid() check to fix that problem.
> 
> Signed-off-by: Andrey Konovalov <andrey.konovalov at linaro.org>
> Cc: Julius Werner <jwerner at chromium.org>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Minkyu Kang <mk7.kang at samsung.com>
> Cc: Marek Vasut <marex at denx.de>

Applied, thanks.

Best regards,
Marek Vasut


More information about the U-Boot mailing list