[U-Boot] [RFC PATCH 1/3] env: drop CONFIG_ENV_VARS_UBOOT_CONFIG support

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Apr 24 03:19:30 CEST 2014


Hi Wolfgang,


On Wed, 23 Apr 2014 21:13:44 +0200
Wolfgang Denk <wd at denx.de> wrote:

> Dear Masahiro,
> 
> In message <20140423210335.18EE.AA925319 at jp.panasonic.com> you wrote:
> > 
> > > Finally, I don't see what your replacement code would be to create the
> > > set of environment settigns - and I think these are needed, as some
> > > user defined scripts are processing these?
> > 
> > The user who needs such environment setting can
> > add them by using CONFIG_EXTRA_ENV_SETTINGS.
> > 
> > For example,
> > 
> > #define CONFIG_EXTRA_ENV_SETTINGS \
> >    "arch=arm\0" \
> >    "cpu=armv7\0" \
> >    "soc=tegra20\0"
> > 
> > I am not sure this is acceptable.
> 
> Neither am I.  What I can see is that this is less flexible - as is,
> we can easily derive these names from the make target name.  Your
> implementation would either be static, or require #ifdefs ?

I agree that people would be unconfortable with this approach.

OK. Please reject this series.


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list