[U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

[Wolfgang Denk]

Dear York Sun,

In message <1398474623-4709-1-git-send-email-yorksun at freescale.com> you wrote:
>
> Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt().

This looks wrong to me.  This is a global file, and you are affecting
a ton of unrelated boards.

> Set initial value for gd. Powerpc SoCs use locked cache as init RAM.

Well, some of them do, not all.

> Change return value for mac_read_from_eeprom() when mismatch happens to
> prevent calling hang().

You mean, you just ignore the error?  This is a change of the cpolicy
that has nothing to do with generic board support, right?  Why should
this be done now, i. e. why has it been accepted and considered to be
working before?

>  board/freescale/common/sys_eeprom.c |    2 +-
>  common/board_f.c                    |   18 +++++++++++++++++-
>  include/configs/MPC8536DS.h         |    2 ++
>  3 files changed, 20 insertions(+), 2 deletions(-)

I think thease are at least 2, eventually 3 independent changes.  You
should split them in several commits.

> +#ifdef CONFIG_PPC
> +	gd = (gd_t *) (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET);
> +	__asm__ __volatile__("":::"memory");
> +#endif

Again, this is a global change.  Why is this now needed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The high cost of living hasn't affected its popularity.