[U-Boot] [PATCH] ARM: exynos: remove the unused code

[Jaehoon Chung]

Hi, Przemyslaw.

On 04/29/2014 05:15 PM, Przemyslaw Marczak wrote:
> Hello Jaehoon,
> 
> On 04/29/2014 10:09 AM, Jaehoon Chung wrote:
>> "mmc boot" command didn't use anywhere.
>> It can be replaced to "mmc dev" command.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>> ---
>>   include/configs/s5pc210_universal.h |    7 ++-----
>>   include/configs/trats.h             |    7 ++-----
>>   include/configs/trats2.h            |   11 +++--------
>>   3 files changed, 7 insertions(+), 18 deletions(-)
>>
>> diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h
>> index 2da8871..db5561a 100644
>> --- a/include/configs/s5pc210_universal.h
>> +++ b/include/configs/s5pc210_universal.h
>> @@ -111,12 +111,9 @@
>>           "onenand write 0x41008000 0xc00000 0x500000\0" \
>>       "bootk=" \
>>           "run loaduimage; bootm 0x40007FC0\0" \
>> -    "updatemmc=" \
>> -        "mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \
>> -        "mmc boot 0 1 1 0\0" \
>>       "updatebackup=" \
>> -        "mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \
>> -        "mmc boot 0 1 1 0\0" \
>> +        "mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \
>> +        "mmc dev 0 0\0" \
>>       "updatebootb=" \
>>           "mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \
>>       "lpj=lpj=3981312\0" \
>> diff --git a/include/configs/trats.h b/include/configs/trats.h
>> index 5d8bd60..694c29c 100644
>> --- a/include/configs/trats.h
>> +++ b/include/configs/trats.h
>> @@ -121,12 +121,9 @@
>>               "bootm 0x40007FC0 - ${fdtaddr};" \
>>           "fi;" \
>>           "bootm 0x40007FC0;\0" \
>> -    "updatemmc=" \
>> -        "mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \
>> -        "mmc boot 0 1 1 0\0" \
>>       "updatebackup=" \
>> -        "mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \
>> -        "mmc boot 0 1 1 0\0" \
>> +        "mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \
>> +        "mmc dev 0 0\0" \
>>       "updatebootb=" \
>>           "mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \
>>       "lpj=lpj=3981312\0" \
>> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
>> index 53d449c..e7a4107 100644
>> --- a/include/configs/trats2.h
>> +++ b/include/configs/trats2.h
>> @@ -111,16 +111,11 @@
>>               "bootm 0x40007FC0 - ${fdtaddr};" \
>>           "fi;" \
>>           "bootm 0x40007FC0;\0" \
>> -    "updatemmc=" \
>> -        "mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200;" \
>> -        "mmc boot 0 1 1 0\0" \
>>       "updatebackup=" \
>> -        "mmc boot 0 1 1 2; mmc write 0x42100000 0 0x200;" \
>> -        " mmc boot 0 1 1 0\0" \
>> +        "mmc dev 0 2; mmc write 0x52100000 0 0x800;" \
>> +        " mmc dev 0 0\0" \
>>       "updatebootb=" \
>> -        "mmc read 0x51000000 0x80 0x200; run updatebackup\0" \
>> -    "updateuboot=" \
>> -        "mmc write 0x50000000 0x80 0x400\0" \
>> +        "mmc read 0x51000000 0x80 0x800; run updatebackup\0" \
> Are you sure that this works fine?
> You load u-boot at 0x51... and then in updatebackup you write it to mmc from another address (0x521...), so it's probably by mistake.
It's my mistake. You're right. it's wrong. :)
I will fix it. Thanks!

Best Regards,
Jaehoon Chung

> 
>>       "mmcboot=" \
>>           "setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \
>>           "${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \
>>
> 
> Thanks