[U-Boot] [PATCH 03/12] MX6: add common SPL configuration

[Tim Harvey]

On Mon, Apr 28, 2014 at 11:37 PM, Igor Grinberg <grinberg at compulab.co.il> wrote:
> Hi,
>
> On 04/29/14 07:14, Eric Nelson wrote:
>> Hi Tim,
>>
>> On 04/28/2014 01:17 PM, Tim Harvey wrote:
>>> Add a common header which can hopefully be shared amon imx6 SPL users
>>>
>>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>>> ---
>>> v2:
>>> - adjust CONFIG_SPL_TEXT_BASE, CONFIG_SPL_STACK and CONFIG_SPL_MAX_SIZE
>>>    to accomodate the IMX6SOLO/DUALLITE which have half the iRAM of the
>>>    IMX6DUAL/IMX6QUAD
>>> ---
>>>   include/configs/imx6_spl.h | 71 ++++++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 71 insertions(+)
>>>   create mode 100644 include/configs/imx6_spl.h
>>>
>>> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
>>> new file mode 100644
>>> index 0000000..20078cc
>>> --- /dev/null
>>> +++ b/include/configs/imx6_spl.h
>>> @@ -0,0 +1,71 @@
>>> +/*
>>> + * Copyright (C) 2014 Gateworks Corporation
>>> + * Author: Tim Harvey <tharvey at gateworks.com>
>>> + *
>>> + * SPDX-License-Identifier:     GPL-2.0+
>>> + */
>>> +#ifndef __IMX6_SPL_CONFIG_H
>>> +#define __IMX6_SPL_CONFIG_H
>>> +
>>> +#ifdef CONFIG_SPL
>>> +
>>> +#define CONFIG_SPL_FRAMEWORK
>>> +
>>> +/*
>>> + * see Figure 8-3 in IMX6DQ/IMX6SDL Reference manuals:
>>
>> s/IMX6SLD/IMX6SDL/g
>>
>>> + *  - IMX6 OCRAM (IRAM) is from 0x00907000 to 0x0091FFFF (IMX6SLD)
>>> + *  - IMX6DQ has 2x IRAM of IMX6SLD but we intend to support IMX6SLD as well
>>
>> ... I was about to complain about the use of IMX6SLD (the nomenclature
>> i.MX6DL/S seems more common), but the RM __is__ named SDL...
>
> SDL stands for Solo/Dual Lite, so SLD is plain wrong...
> (Solo Lite and Dual are so different...)
>
>
> --
> Regards,
> Igor.

Igor / Eric,

Yes this was definitely a typo - no idea how I kept making the same
typo over and over again... late nights!

I'll fix this for the next revision and refer to the CPU types as
'IMX6DQ' and 'IMX6SDL'.

Please let me know if there is anything else you see that needs to be discussed.

Tim