[U-Boot] [PATCH v5 03/12] usb: dfu: fix boards wo USB cable detection

Marek Vasut marex at denx.de
Wed Apr 30 10:18:11 CEST 2014


On Monday, April 28, 2014 at 09:13:23 PM, Mateusz Zalega wrote:
> Former usb_cable_connected() patch broke compilation of boards which do
> not support this feature.
> 
> I've renamed usb_cable_connected() to g_dnl_usb_cable_connected() and added
> its default implementation to gadget downloader driver code. There's
> only one driver of this kind and it's unlikely there'll be another, so
> there's no point in keeping it in /common.
> 
> Previously this function was declared in usb.h. I've moved it, since
> it's more appropriate to keep it in g_dnl.h - usb.h seems to be intended
> for USB host implementation.
> 
> Existing code, confronted with default -EOPNOTSUPP return value,
> continues as if the cable was connected.
> 
> CONFIG_USB_CABLE_CHECK was removed.
> 
> Signed-off-by: Mateusz Zalega <m.zalega at samsung.com>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Marek Vasut <marex at denx.de>

Acked-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list