[U-Boot] [PATCH v5 02/12] part: header fix

Lukasz Majewski l.majewski at samsung.com
Wed Apr 30 10:33:23 CEST 2014


Hi Tom,

> Implementation made use of types defined in common.h, even though it
> wasn't #included. It worked in circumstances when .c files included
> every needed header (all).
> 
> Signed-off-by: Mateusz Zalega <m.zalega at samsung.com>
> Cc: Tom Rini <trini at ti.com>
> Cc: Minkyu Kang <mk7.kang at samsung.com>
> ---
> Changes since v1:
> - none
> ---
>  include/part.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/part.h b/include/part.h
> index 4beb6db..53532dc 100644
> --- a/include/part.h
> +++ b/include/part.h
> @@ -8,6 +8,7 @@
>  #define _PART_H
>  
>  #include <ide.h>
> +#include <common.h>
>  
>  typedef struct block_dev_desc {
>  	int		if_type;	/* type of the interface
> */

I've agreed with Marek Vasut about those patches. I will take them to
u-boot-dfu tree and send PR to Marek.

Since this is a cleanup patch (not connected to DFU/USB) I would like
to take it to the u-boot-dfu to prevent it from being vanished on the
ML.

Tom, could you ACK this patch? And then I will add it to u-boot-dfu.


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list