[U-Boot] [PATCH v5 01/16] arm: ls102xa: Add Freescale LS102xA SoC support

[Mark Rutland]

On Wed, Aug 20, 2014 at 03:39:37AM +0100, AlisonWang wrote:
> Hi, Mark,
> 
> On Tue, Aug 19, 2014 at 03:54:50AM +0100, Alison Wang wrote:
> 
> > +int timer_init(void) 
> > +{ 
> > +       struct sctr_regs *sctr = (struct sctr_regs *)SCTR_BASE_ADDR; 
> > +       unsigned long ctrl, val, freq; 
> > + 
> > +       /* Enable System Counter */ 
> > +       writel(SYS_COUNTER_CTRL_ENABLE, &sctr->cntcr); 
> > + 
> > +       freq = GENERIC_TIMER_CLK; 
> > +       asm("mcr p15, 0, %0, c14, c0, 0" : : "r" (freq));
> 
> Is CNTFRQ initialised for both CPUs? 
> 
> [Alison Wang] No, only one CPU is booted now.

Ah, ok. I missed that.

> If the CPUs are booted at PL1 rather than PL2, is CNTVOFF initialised to 
> the same value on both CPUs? 
> 
> [Alison Wang] CNTVOFF is not initialized in the current secure mode. When
> we add virtualization support and switch to non-secure mode, we will
> initialize CNTVOFF to zero on both CPUs.

Ok. So long as CNTFRQ is also initialised that sounds fine.

Thanks,
Mark.