[U-Boot] [PATCH 00/25] x86: Add Intel Queensbay platform support

[Simon Glass]

Hi Bin,

On 5 December 2014 at 07:07, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Fri, Dec 5, 2014 at 8:04 AM, Simon Glass <sjg at chromium.org> wrote:
> > Hi Bin,
> >
> > On 4 December 2014 at 08:00, Bin Meng <bmeng.cn at gmail.com> wrote:
> >> This patch series add the Intel Queensbay platform support. The Queensbay
> >> platform includes an Atom E6xx processor (codename Tunnel Creek) and a
> >> Platform Controller Hub EG20T (codename Topcliff). The support depends
> >> on Intel Firmware Support Package (FSP) to initialize the processor and
> >> chipset including system memory. With this patch series, U-Boot boots to
> >> Linux kernel. Validated on an Intel Crown Bay board with kernel 3.17.
> >>
> >> Note I did not clean up the original FSP codes released by Intel with
> >> U-Boot coding convention. So there will be coding style issues reported
> >> by the patch checkers against patch#11 and #12 in this series.
> >
> > I've acked some of this - let me know if you would like me to apply
> > things out of order, etc. Otherwise I'll wait.
>
> Thanks for acking/reviewing them so quickly! Let me rework and send
> the v2 patch series so that you can apply them one-time.

OK sounds good. Can we clarify the code style side of things? Since it
is a binary blob I don't feel like we are stuck with the Intel code
style. We could using existing U-Boot types, change the mixed case
stuff and tidy up comment style.

For fsp_support.c the code doesn't look all that tidy.

Regards,
Simon