[U-Boot] [PATCH v2 10/27] x86: Initial import from Intel FSP release for Queensbay platform

Simon Glass sjg at chromium.org
Wed Dec 10 06:53:05 CET 2014


Hi Bin,

On 9 December 2014 at 07:49, Bin Meng <bmeng.cn at gmail.com> wrote:
> This is the initial import from Intel FSP release for Queensbay
> platform (Tunnel Creek processor and Topcliff Platform Controller
> Hub), which can be downloaded from Intel website.
>
> For more details, check http://www.intel.com/fsp.
>
> Note: U-Boot coding convention was applied to these codes, so it
> looks completely different from the original Intel release.

Yes but I don't think this goes far enough. You still have things like
UINT32, capital letter types, typedefs and so on. Since this is a
standard interface, even though it is painful (lots of global replace)
I think it is worth making it 100% U-Boot style compliance.

Regards,
Simon

>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
>
> Changes in v2:
> - Apply U-Boot coding convention to the FSP support codes
>
>  arch/x86/cpu/queensbay/fsp_configs.c               |  51 +++
>  arch/x86/cpu/queensbay/fsp_support.c               | 428 +++++++++++++++++++++
>  arch/x86/include/asm/arch-queensbay/fsp/fsp_api.h  |  79 ++++
>  .../include/asm/arch-queensbay/fsp/fsp_bootmode.h  |  47 +++
>  arch/x86/include/asm/arch-queensbay/fsp/fsp_ffs.h  | 189 +++++++++
>  arch/x86/include/asm/arch-queensbay/fsp/fsp_fv.h   | 213 ++++++++++
>  arch/x86/include/asm/arch-queensbay/fsp/fsp_hob.h  | 341 ++++++++++++++++
>  .../asm/arch-queensbay/fsp/fsp_infoheader.h        |  59 +++
>  .../include/asm/arch-queensbay/fsp/fsp_platform.h  |  42 ++
>  .../include/asm/arch-queensbay/fsp/fsp_support.h   | 219 +++++++++++
>  .../x86/include/asm/arch-queensbay/fsp/fsp_types.h | 171 ++++++++
>  arch/x86/include/asm/arch-queensbay/fsp/fsp_vpd.h  |  81 ++++
>  12 files changed, 1920 insertions(+)
>  create mode 100644 arch/x86/cpu/queensbay/fsp_configs.c
>  create mode 100644 arch/x86/cpu/queensbay/fsp_support.c
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_api.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_bootmode.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_ffs.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_fv.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_hob.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_infoheader.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_platform.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_support.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_types.h
>  create mode 100644 arch/x86/include/asm/arch-queensbay/fsp/fsp_vpd.h
>


More information about the U-Boot mailing list