[U-Boot] [PATCH v2 10/27] x86: Initial import from Intel FSP release for Queensbay platform

Bin Meng bmeng.cn at gmail.com
Wed Dec 10 07:01:32 CET 2014


Hi Simon,

On Wed, Dec 10, 2014 at 1:53 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 9 December 2014 at 07:49, Bin Meng <bmeng.cn at gmail.com> wrote:
>> This is the initial import from Intel FSP release for Queensbay
>> platform (Tunnel Creek processor and Topcliff Platform Controller
>> Hub), which can be downloaded from Intel website.
>>
>> For more details, check http://www.intel.com/fsp.
>>
>> Note: U-Boot coding convention was applied to these codes, so it
>> looks completely different from the original Intel release.
>
> Yes but I don't think this goes far enough. You still have things like
> UINT32, capital letter types, typedefs and so on. Since this is a
> standard interface, even though it is painful (lots of global replace)
> I think it is worth making it 100% U-Boot style compliance.
>
> Regards,
> Simon
>

Yes, the checkpatch.pl reported all these typedefs warnings. I
intended not to clean these up, but if you think we should do that, I
will resend v3.

Regards,
Bin


More information about the U-Boot mailing list