[U-Boot] [PATCH 2/6] usb:udc:samsung: Remove redundant cache operation from Samsung UDC driver

Marek Vasut marex at denx.de
Sat Feb 1 03:50:26 CET 2014


On Friday, January 31, 2014 at 01:16:25 PM, Lukasz Majewski wrote:
> A set of cache operations (both invalidation and flush) were redundant
> in the S3C HS OTG Samsung driver.
> 
> Test condition
> - test HW + measurement: Trats - Exynos4210 rev.1
> - test HW Trats2 - Exynos4412 rev.1
> 400 MiB compressed rootfs image download with `thor 0 mmc 0`

The commit message is missing a proper explanation _WHY_ were they redundant. I 
do not understand why they were redundant ... and no, the test you performed 
does not justify removal of cache management calls.

Best regards,
Marek Vasut


More information about the U-Boot mailing list