[U-Boot] [PATCH V2 1/8] arm:exynos: add cpu revision
Minkyu Kang
mk7.kang at samsung.com
Mon Feb 3 09:18:24 CET 2014
Dear Wolfgang Denk,
On 23/01/14 19:28, Wolfgang Denk wrote:
> Dear Piotr Wilczek,
>
> In message <1390402477-24340-2-git-send-email-p.wilczek at samsung.com> you wrote:
>> This patch enables to read cpu revision on Exynos CPU.
>
> Sorry, you really need to refactor your patches.
>
> In this commit you add references to "s5p_cpu_id":
>
>> @@ -196,10 +198,12 @@ static inline void s5p_set_cpu_id(void)
>> case 0x210:
>> /* Exynos4210 EVT1 */
>> s5p_cpu_id = 0x4210;
>> + s5p_cpu_rev = cpu_rev;
>> break;
>> case 0x412:
>> /* Exynos4412 */
>> s5p_cpu_id = 0x4412;
>> + s5p_cpu_rev = cpu_rev;
>> break;
>> case 0x520:
>> /* Exynos5250 */
>
> But this variable does not exist anywhere. It is only added in the
> next patch. Adding this patch causes build breakage, i. e. your patch
> series is not bisectable.
s5p_cpu_id and s5p_cpu_rev exist on "arch/arm/cpu/armv7/s5p-common/cpu_info.c".
This patch looks fine to me.
Thanks,
Minkyu Kang.
More information about the U-Boot
mailing list