[U-Boot] [PATCH v3 6/9] arc: add Arcangel4 board support

Wolfgang Denk wd at denx.de
Mon Feb 3 20:15:52 CET 2014


Dear Alexey Brodkin,

In message <1391445368-10545-7-git-send-email-abrodkin at synopsys.com> you wrote:
> Arcangel4 is a FPGA-based development board that is used for prototyping and
> verification of of both ARC hardware (CPUs) and software running upon CPU.
> 
> Prerequisite is http://patchwork.ozlabs.org/patch/300901/

Is this commentuseful in the commit message?


> +#define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0x200)
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x1234)

This definitely makes no sense at all.  Please see bullet 2. in
doc/README.memory-test

> +#define CONFIG_BAUDRATE			115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, 115200}

This is standard, isn't it? So you can omit it.


...
> +#define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0x200)
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x1234)
...
> +#define CONFIG_BAUDRATE			115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, 115200}

See above.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HANDLE WITH EXTREME CARE:  This Product Contains  Minute Electrically
Charged  Particles  Moving  at  Velocities  in Excess of Five Hundred
Million Miles Per Hour.


More information about the U-Boot mailing list