[U-Boot] [PATCH V4 01/12] fs: fix generic save command implementation

Tom Rini trini at ti.com
Tue Feb 4 23:06:01 CET 2014


On Mon, Feb 03, 2014 at 01:20:59PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren at nvidia.com>
> 
> Fix a few issues with the generic "save" shell command, and fs_write()
> function.
> 
> 1) fstypes[].write wasn't filled in for some file-systems, and isn't
>    checked when used, which could cause crashes/... if executing save
>    on e.g. fat/ext filesystems.
> 
> 2) fs_write() requires the length argument to be non-zero, since it needs
>    to know exactly how many bytes to write. Adjust the comments and code
>    according to this.
> 
> 3) fs_write() wasn't prototyped in <fs.h> like other generic functions;
>    other code should be able to call this directly rather than invoking
>    the "save" shell command.
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140204/93ac274f/attachment.pgp>


More information about the U-Boot mailing list