[U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

[Wolfgang Denk]

Dear Tim Harvey,

In message <1391642553-25778-1-git-send-email-tharvey at gateworks.com> you wrote:
> Gateworks Ventana is a product family based on the i.MX6.  This
> patch adds support for all boards in the Ventana family. Where
> possible, data from the boards EEPROM is used to determine various
> details about the board at runtime.
...
> +#define MINMAX(n, percent)	n*(1.0-percent/100), n*(1.0+percent/100)

U-Boot is integer arithmetics only.  You must not use any FP
calculations in the code.


> +/*
> + * Hardware Monitor
> + */
> +#define GSC_HWMON_TEMP		0x00
> +#define GSC_HWMON_VIN		0x02
> +#define GSC_HWMON_VDD_3P3	0x05
> +#define GSC_HWMON_VBATT		0x08
> +#define GSC_HWMON_VDD_5P0	0x0b
> +#define GSC_HWMON_VDD_CORE	0x0e
> +#define GSC_HWMON_VDD_HIGH	0x14
> +#define GSC_HWMON_VDD_DDR	0x17
> +#define GSC_HWMON_VDD_SOC	0x11
> +#define GSC_HWMON_VDD_1P8	0x1d
> +#define GSC_HWMON_VDD_2P5	0x23
> +#define GSC_HWMON_VDD_1P0	0x20

I'd really like to see a C struct here to describe the register
layout...


> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> new file mode 100644
> index 0000000..1a18d93
...
> +  #define CONFIG_SPI_FLASH_WINBOND_ERASESIZE 64*1024  /* 4,32,64K for W26Q256 */


This causes a checkpatch error:

ERROR: Macros with complex values should be enclosed in parenthesis

Please fix!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of anthropomorphic terminology when  dealing  with  computing
systems is a symptom of professional immaturity.   -- Edsger Dijkstra