[U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

[Wolfgang Denk]

Dear Tim,

In message <CAJ+vNU2udV1yEUjh79UZNf01jtAmde7P8u-g_x1heNdg7mkZVQ at mail.gmail.com> you wrote:
>
> > > +/*
> > > + * Hardware Monitor
> > > + */
> > > +#define GSC_HWMON_TEMP               0x00
> > > +#define GSC_HWMON_VIN                0x02
> > > +#define GSC_HWMON_VDD_3P3    0x05
> > > +#define GSC_HWMON_VBATT              0x08
> > > +#define GSC_HWMON_VDD_5P0    0x0b
> > > +#define GSC_HWMON_VDD_CORE   0x0e
> > > +#define GSC_HWMON_VDD_HIGH   0x14
> > > +#define GSC_HWMON_VDD_DDR    0x17
> > > +#define GSC_HWMON_VDD_SOC    0x11
> > > +#define GSC_HWMON_VDD_1P8    0x1d
> > > +#define GSC_HWMON_VDD_2P5    0x23
> > > +#define GSC_HWMON_VDD_1P0    0x20
> >
> > I'd really like to see a C struct here to describe the register
> > layout...
> 
> you mean enum right?

No, actually I mean a struct - but on closer look I am not really sure
if these numbers are offsets against a device base address or actually
I2C addresses?

> > This causes a checkpatch error:
> >
> > ERROR: Macros with complex values should be enclosed in parenthesis
> >
> > Please fix!
> 
> what args do you run checkpatch.pl with?  The default args does not
> check COMPLEX_MACRO it would seem which is why I missed that.

It appears I happen to run an older version of checkpatch.pl; I have
no idea why COMPLEX_MACRO (and MULTISTATEMENT_MACRO_USE_DO_WHILE) are
disabled in the current code.


Tom, what do you think?  Should we not activate the COMPLEX_MACRO and
MULTISTATEMENT_MACRO_USE_DO_WHILE checks?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you want to eat hippopatomus, you've got to pay the  freight."  -
attributed to an IBM guy, about why IBM software uses so much memory