[U-Boot] [PATCH 5/9] arm:exynos: add common board file for exynos 4

[Minkyu Kang]

On 07/02/14 17:40, Piotr Wilczek wrote:
> Dear Minkyu Kang,
> 
>> -----Original Message-----
>> From: Minkyu Kang [mailto:mk7.kang at samsung.com]
>> Sent: Friday, February 07, 2014 8:53 AM
>> To: Piotr Wilczek
>> Cc: u-boot at lists.denx.de; Kyungmin Park; Lukasz Majewski; Jaehoon
>> Chung; Inha Song; Chanho Park
>> Subject: Re: [PATCH 5/9] arm:exynos: add common board file for exynos 4
>>
>> On 27/01/14 23:15, Piotr Wilczek wrote:
>>> This patch adds common board file for Exynos 4 based boards.
>>>
>>> Signed-off-by: Piotr Wilczek <p.wilczek at samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>>> ---
>>>  arch/arm/dts/exynos4.dtsi            |  139
>> +++++++++++++++++++++++++++
>>>  board/samsung/common/Makefile        |    1 +
>>>  board/samsung/common/board_exynos4.c |   83 +++++++++++++++++
>>>  include/configs/exynos4-dt.h         |  170
>> ++++++++++++++++++++++++++++++++++
>>>  4 files changed, 393 insertions(+)
>>>  create mode 100644 arch/arm/dts/exynos4.dtsi  create mode 100644
>>> board/samsung/common/board_exynos4.c
>>>  create mode 100644 include/configs/exynos4-dt.h
>>>
>>> diff --git a/board/samsung/common/Makefile
>>> b/board/samsung/common/Makefile index 7d2bb8c..25f1e40 100644
>>> --- a/board/samsung/common/Makefile
>>> +++ b/board/samsung/common/Makefile
>>> @@ -12,4 +12,5 @@ obj-$(CONFIG_MISC_COMMON) += misc.o
>>>
>>>  ifndef CONFIG_SPL_BUILD
>>>  obj-$(CONFIG_BOARD_COMMON)	+= board.o
>>> +obj-$(CONFIG_BOARD_COMMON_EXYNOS4)	+= board_exynos4.o
>>>  endif
>>> diff --git a/board/samsung/common/board_exynos4.c
>>> b/board/samsung/common/board_exynos4.c
>>> new file mode 100644
>>> index 0000000..2d313e6
>>> --- /dev/null
>>> +++ b/board/samsung/common/board_exynos4.c
>>
>> I don't understand why need exynos4 common board file.
>> There's already exist board.c that is common board file for samsung.
>>
> Because in the board.c file, both common and board specific functions are
> added.
> Max 77686, eth, power, board late initialization functions are board
> specific.
> If they are removed, I will be able to use the board.c file.

It seems to be wrapped with ifdef.
I think there's no problems to use same file.

Thanks,
Minkyu Kang.