[U-Boot] [PATCH 1/3] fit: Add support for SHA256 hash

Marek Vasut marex at denx.de
Sat Feb 8 15:17:29 CET 2014


On Thursday, February 06, 2014 at 01:17:36 PM, Wolfgang Denk wrote:
> Dear Marek,
> 
> In message <1391658426-24799-1-git-send-email-marex at denx.de> you wrote:
> > This patch adds support for SHA-256 hash into the FIT image. The usage is
> 
> > as with the other hashing algorithms:
> ...
> 
> > -#define FIT_MAX_HASH_LEN	20	/* max(crc32_len(4), sha1_len(20)) */
> > +#define FIT_MAX_HASH_LEN	32	/* max(crc32_len(4), sha1_len(20),
> > sha256_len(32)) */
> 
> Line too long.
> 
> Please make sure to run your patches through checkpatch !

This is weird, since all my patches should be checked upon 'git commit' via 
hook. Thanks for bringing this up to my attention, I will verify that.

Nonetheless, I would vouch for applying Heiko's patches instead.

Best regards,
Marek Vasut


More information about the U-Boot mailing list