[U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

[Tim Harvey]

On Thu, Feb 6, 2014 at 4:07 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Tim,
>
> In message <CAJ+vNU2udV1yEUjh79UZNf01jtAmde7P8u-g_x1heNdg7mkZVQ at mail.gmail.com> you wrote:
>>
>> > > +/*
>> > > + * Hardware Monitor
>> > > + */
>> > > +#define GSC_HWMON_TEMP               0x00
>> > > +#define GSC_HWMON_VIN                0x02
>> > > +#define GSC_HWMON_VDD_3P3    0x05
>> > > +#define GSC_HWMON_VBATT              0x08
>> > > +#define GSC_HWMON_VDD_5P0    0x0b
>> > > +#define GSC_HWMON_VDD_CORE   0x0e
>> > > +#define GSC_HWMON_VDD_HIGH   0x14
>> > > +#define GSC_HWMON_VDD_DDR    0x17
>> > > +#define GSC_HWMON_VDD_SOC    0x11
>> > > +#define GSC_HWMON_VDD_1P8    0x1d
>> > > +#define GSC_HWMON_VDD_2P5    0x23
>> > > +#define GSC_HWMON_VDD_1P0    0x20
>> >
>> > I'd really like to see a C struct here to describe the register
>> > layout...
>>
>> you mean enum right?
>
> No, actually I mean a struct - but on closer look I am not really sure
> if these numbers are offsets against a device base address or actually
> I2C addresses?

These are register offsets, not i2c addresses.  An enum makes sense to
me.  Can you point me to an example of a struct your talking about?

Thanks,

Tim