[U-Boot] Question about Coding-Style

[Chris Moore]

Hi Albert,
Le 10/02/2014 10:58, Albert ARIBAUD a écrit :
> Hi Tom,
>
> On Tue, 4 Feb 2014 10:07:32 -0500, Tom Rini<trini at ti.com>  wrote:
>
>> On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote:
>>> Hi Hannes,
>>>
>>> On 04/02/2014 15:50, Hannes Petermaier wrote:
>> [snip]
>>>> Another thing is linewrapping of output strings, to obey to the rules i
>>>> have to format the string as following:
>>>>
>>>> if (i2c_probe(TPS65217_CHIP_PM)) {
>>>> 	printf("PMIC chip (0x%02x) not present! skipping" \
>>>> 		"further configuration.\n", TPS65217_CHIP_PM);
>>>> 	return;
>>>> }
>>>>
>>>> But this makes it impossible to grep the code in case of an error.
>>> You must combine a more complicate grep, maybe with the -A (after
>>> context) option or using a regexp. However, this is not a reason to
>>> break the rule.
>> Strings are the reason to break the rule and we have checkpatch patched
>> (mostly?) to not complain.  It's even true in the kernel.
> Hmm... Last time I checked,
>
> 	"abc"
> 	"def"
>
> Is a valid C string, and does not require a backslash. Do I miss
> something?

Yes, you are of course correct: the result is the C string "abcdef" and 
the backslash in the original is superfluous.
However a grep for "abcdef" in the source code won't match it :(
This is why splitting strings like this is discouraged in the Linux kernel.

Cheers,
Chris


---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active.
http://www.avast.com